D16299: fallback to dnssd service discovery if smb listDir failed on root

This revision was automatically updated to reflect the committed changes. Closed by commit R320:55eb68ff6364: fallback to dnssd service discovery if smb listDir failed on root (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D16299: fallback to dnssd service discovery if smb listDir failed on root

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-discovery REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin, broulik Cc: acrouthamel, alexde, bcooksley, ngraham,

D16299: fallback to dnssd service discovery if smb listDir failed on root

ngraham added inline comments. INLINE COMMENTS > sitter wrote in kio_smb_browse.cpp:508 > https://en.wikipedia.org/wiki/If_and_only_if How about writing that out in English, then? :) "iff" just looks like a typo in this context. REPOSITORY R320 KIO Extras REVISION DETAIL

D16299: fallback to dnssd service discovery if smb listDir failed on root

acrouthamel added a comment. In D16299#363498 , @sitter wrote: > If someone has a thought to offer on this please do. > Personally I am somewhat leaning towards assuming that systems should be properly configured. The problem with setting the

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. // TODO: it may be better to resolve the host to an ip address. dnssd // being able to find a service doesn't mean name resolution is // properly set up for its domain. So, we may not be able to resolve // this without help from avahi. OTOH KDNSSD

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef,

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter retitled this revision from "RFC fallback to dnssd service discovery if smb listDir failed on root" to "fallback to dnssd service discovery if smb listDir failed on root". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks,