This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2b20e8720ae3: add explicit to constructors (authored by
astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16618?vs=44731&id=44822
REVISION DETAIL
mgallien accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
explicit
REVISION DETAIL
https://phabricator.kde.org/D16618
To: astippich, #frameworks, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, #baloo, ashaposhnikov, michael
astippich updated this revision to Diff 44731.
astippich added a comment.
- don't change exported classes
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16618?vs=44724&id=44731
BRANCH
explicit
REVISION DETAIL
https://phabricator.kde.org/D16618
astippich planned changes to this revision.
astippich added inline comments.
INLINE COMMENTS
> mgallien wrote in simpleextractionresult.h:42
> Given this class is exported, is this binary compatible ?
I've been not really thinking about it while I was looking at the EBN stuff and
pushed too fas
mgallien added inline comments.
INLINE COMMENTS
> simpleextractionresult.h:42
> public:
> -SimpleExtractionResult(const QString& url, const QString& mimetype =
> QString(), const Flags& flags = ExtractEverything);
> +explicit SimpleExtractionResult(const QString& url, const QString&
>
astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
add explicit to constructors as suggested by EBN
REPOSITO
