apol added inline comments.
INLINE COMMENTS
> unit.h:65
> +ElectricalResistanceCategory,
> +PermeabilityCategory
> };
`/** @since 5.53 */` is needed here too.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D16681
To: joaonetto, ngraham, broulik,
joaonetto abandoned this revision.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D16681
To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.
Great job, and nice first patch!
Unfortunately, this doesn't compile:
-- Configuring done
CMake Error at
joaonetto edited the summary of this revision.
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D16681
To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
joaonetto updated this revision to Diff 44901.
joaonetto added a comment.
Updating D16681 <https://phabricator.kde.org/D16681>: Updated with petroleum
industry units
REPOSITORY
R292 KUnitConversion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16681?vs=44899=44901
joaonetto created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
joaonetto requested review of this revision.
REVISION SUMMARY
Added a new volume unity Oil Barrels and a new permeability class that
handles Darcy and MiliDarcys.
REPOSITORY
