D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R858:8fa114df0ad1: Fix issue where theres only one element on the menu (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Marco Martin
mart accepted this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D16685 To: apol, #frameworks, mart, ngraham Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems like this is only a problem if you have a single-item menu, and if you have that, you've done something wrong. :) Regardless, this seems to fix the issue, so +1. REPOSITORY R858

D16685: Fix issue where there's only one element on the menu

2018-11-05 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This (random) height shows an odd padding on the menu when there's just the one element.