D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e2270613fc25: Add new icons for root (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16772?vs=45209=45213 REVISION

D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
ngraham added a comment. Other VDG folks in chat seem happy as well. Landing it! Nice work. REPOSITORY R266 Breeze Icons BRANCH folder-root (branched from master) REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg, ngraham Cc: ngraham, #vdg,

D16772: Add new icons for root

2018-11-09 Thread Nathaniel Graham
ngraham added a comment. Usually the time is right when someone recommends that you do so! :-) REPOSITORY R266 Breeze Icons BRANCH folder-root (branched from master) REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg, ngraham Cc: ngraham, #vdg, kde-frameworks-devel,

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis added a comment. In D16772#357086 , @ngraham wrote: > Makes sense to me. Now that I see them all together, I agree that /_ is a bit better. It seems much better for the folder, and at least no worse (and probably a bit better) for the

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis updated this revision to Diff 45208. ndavis added a comment. Update commit message to more accurately describe the changes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16772?vs=45196=45208 BRANCH folder-root (branched from master)

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis updated this revision to Diff 45196. ndavis added a comment. Change style to `/_`. The reason for this is that `/` by itself looks kind of empty and it's easy to confuse the meaning with disabled or inactive, especially for drive-harddisk-root. REPOSITORY R266 Breeze Icons CHANGES

D16772: Add new icons for root

2018-11-09 Thread Noah Davis
ndavis retitled this revision from "Add folder-root icon" to "Add new icons for root". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg,