D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-17 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R318:e710a6431160: Do not disconnect all StorageAccess signals when unmounting (authored by thsurrel). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-17 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks, this fixes the bug for me. I think we can ship it on the stable branch (`Applications/18.12`) REPOSITORY R318 Dolphin BRANCH arc_remount_local (branched

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Thomas Surrel
thsurrel edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16857 To: thsurrel, #dolphin, #frameworks, bruns Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Stefan BrĂ¼ns
bruns added a comment. I think this is correct, but the summary can be improved a little bit. The problem is caused by the fact device interfaces returned by Solid (e.g. `item->device().as()`) are not full objects, but only references/pointers to a per-device-object, i.e. requesting the

D16857: Do not disconnect all StorageAccess signals when unmounting

2018-11-13 Thread Nathaniel Graham
ngraham edited reviewers, added: Frameworks, bruns; removed: VDG. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D16857 To: thsurrel, #dolphin, #frameworks, bruns, #vdg Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros,