This revision was automatically updated to reflect the committed changes.
Closed by commit R238:0a714c220662: Fix running kdoctools-install autotest
without kdoctools installed (authored by habacker).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Works, I'm not a kdoctools *real* expert so maybe you want to wait for
someone else to approve, but i'd say just commit, i mean i don't think it's
worse than what we have now and the test
habacker marked an inline comment as done.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D16963
To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna
habacker updated this revision to Diff 45690.
habacker added a comment.
- fix parallel builds
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16963?vs=45685=45690
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16963
AFFECTED FILES
aacid added a comment.
Cool test passes now, **BUT** see comment
INLINE COMMENTS
> KF5DocToolsMacros.cmake:205
> set(_bootstrapOption "--srcdir=${KDocTools_BINARY_DIR}/src")
> -set(_extraDependency "docbookl10nhelper")
> elseif (CMAKE_CROSSCOMPILING AND
habacker added a reviewer: aacid.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D16963
To: habacker, aacid
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna
habacker created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
habacker requested review of this revision.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16963
