D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c7095834d282: Expose Toggle Comment feature through tools menu and default shortcut (authored by slenz, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

cullmann accepted this revision. cullmann added a comment. As long as the old shortcuts stay, I think this is ok. REPOSITORY R39 KTextEditor BRANCH arcpatch-D17008_1 REVISION DETAIL https://phabricator.kde.org/D17008 To: slenz, #vdg, ngraham, #kate, #ktexteditor, cullmann Cc:

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

ngraham accepted this revision. ngraham added reviewers: Kate, KTextEditor. ngraham added a comment. This revision is now accepted and ready to land. Looks good from my perspective! Let's see what the #kate folks think. INLINE COMMENTS > slenz wrote

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz marked an inline comment as done. slenz added inline comments. INLINE COMMENTS > ngraham wrote in katepart5ui.rc:2 > You need to bump the version to 79 or else the changes won't take effect. That might explain why the changes only sometimes appeared. Fixed :) > ngraham wrote in

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz updated this revision to Diff 45841. slenz added a comment. Increment menubar file version number REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17008?vs=45788=45841 BRANCH arcpatch-D17008_1 REVISION DETAIL https://phabricator.kde.org/D17008

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Lovely, this is just what I wanted. It's cool that the feature was already there. :) I like how you preserve the old shortcuts for compatibility. Just a few changes needed from

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17008 To: slenz, #vdg Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17008: Expose "Toggle Comment" feature through tools menu and default shortcut

slenz created this revision. slenz added a reviewer: VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. slenz requested review of this revision. REVISION SUMMARY Adds a menu item to toggle comments and adds CTRL + / as a shortcut. Also