kfunk added a comment.
Yep, those are in fact separate commits.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17031
To: kfunk, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:421e1c01266e: ASAN: Fix memory leak in CalendarPlugin
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17031?vs=45849=45891#toc
REPOSITORY
R242 Plasma Framework (Library)
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17031
To: kfunk, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
mart added a comment.
looks good, thanks :)
tough those fixes are quite unrelated, can they be made in separated commits?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D17031
To: kfunk
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns
kfunk created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kfunk requested review of this revision.
REVISION SUMMARY
Direct leak of 3960 byte(s) in 15 object(s) allocated from:
#0 0x544cc0 in operator new(unsigned long)
