D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann commandeered this revision. cullmann added a reviewer: gregormi. cullmann added a comment. I think we need to start here from scratch. Gregor, if you have some time again, open a new request please! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: cullmann, #kate, #kdevelop, gregormi Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

mwolff resigned from this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

loh.tar added a comment. Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic. I may like it if these "Variant-Action" could be avoided and merged with one of the

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. Lookin' pretty good! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. What I wonder: during the work with the .rc files I noticed that even the Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal?

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi marked an inline comment as done. gregormi added a comment. This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138): F6547077: grafik.png REPOSITORY R39 KTextEditor REVISION DETAIL

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi updated this revision to Diff 49369. gregormi added a comment. - Move "Save As..." out of the submenu REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17137?vs=46132=49369 BRANCH arcpatch-D17137 REVISION DETAIL

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

anthonyfieroni added inline comments. INLINE COMMENTS > katepart5ui.rc:2 > > > Increase version REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel,

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. For me, too. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. In D17137#379789 , @gregormi wrote: > If there are no further comments, would proceed with: > > - Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants' > -

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. If there are no further comments, would proceed with: - Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants' - Introduce "Print and Export" submenu - Introduce "Close Variants" while leaving the

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. In terms of the submenu text, I just noticed that we already have "Find Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close variants" for consistency. We can decide later whether we want to keep that style. REPOSITORY R39 KTextEditor

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. For: Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended. Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi added a comment. +1 for leaving Save As on top level. Just for reference the File menu of the current master on my screen :) F6464245: grafik.png As for me, at least all the Close actions could be moved into a submenu. REPOSITORY

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a comment. Maybe file_save_alternatives or as Gregor once suggested file_save_variants. Or file_save_extended. Btw, do we have an issue that Kate (kateui.rc) and KTextEditor (katepart5ui.rc) use different release schedules? Does that imply issues with XMLGUI merging?

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

cullmann added a comment. I think grouping these not that often used things is ok. I would keep "save as" toplevel. One thing to clarify: How do we get the "Save All" of Kate inside the file_save2 menu? I assume we should name the menu better and reuse that name inside kateui.rc.

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a subscriber: cullmann. dhaumann added a comment. @cullmann You did not seem to have strong objections to this. Can you comment on this here again? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: cullmann,

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

flherne added a comment. Please no. `File -> Save` is one of the most universal menu entries, found in nearly every program that *has* a set of menus. Print is nearly as common. This breaks a user assumption that's been ingrained across virtually all GUI software for decades, and

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a comment. Hm, is this really a good idea? Right now, the File menu is rather flat, which is a good thing imo. Do we really want to move Save operations into a "Save Variants" sub menu? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To:

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

gregormi retitled this revision from "File menu: Put Save, Print and Export in submenus" to "KTextEditor: File menu: Put Save, Print and Export in submenus". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: kwrite-devel,