D17199: Add unittest to check if commiting the same change twice works

2018-12-01 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:f0c68be03694: Add unittest to check if commiting the same change twice works (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17199?vs=46349&id=466

D17199: Add unittest to check if commiting the same change twice works

2018-12-01 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, it applies now that the other patch is in. Works great, looks good. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17199 To: bruns, #baloo,

D17199: Add unittest to check if commiting the same change twice works

2018-12-01 Thread Stefan Brüns
bruns added a comment. Conceptually, its independent of D17198 , but there is a single line not matching in the context Try again with currennt master REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17199 To: bruns, #baloo, #fr

D17199: Add unittest to check if commiting the same change twice works

2018-12-01 Thread Nathaniel Graham
ngraham added a comment. Patch does not apply for me on top of current master: Ignore these untracked files and continue? [y/N] y INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D17199. This diff i

D17199: Add unittest to check if commiting the same change twice works

2018-11-27 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The fileindexer is only aware some terms/properties *may*