sars updated this revision to Diff 48461.
sars added a comment.
Disable highlighting after [limit] characters on a line in stead of the whole
line.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17241?vs=47146&id=48461
BRANCH
disable_hl2
REVISION DE
sars added a comment.
@zetazeta I'm not sure the highlighting length limit is worth an option as
the editing of the document is not effected. I it is just a bit inconvenient
that the highlighting disappears...
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
sars marked 2 inline comments as done.
sars added a comment.
@dhaumann: You are right, the highlighting of the document still takes place
and it is only KateRenderer that stops using the highlighting info for all
lines longer than 1024 characters. All shorter lines are highlighted.
So th
sars updated this revision to Diff 47146.
sars added a comment.
- Use a bit different config key to force a value reset for the limit.
- Fix reading the config value.
- Update the line-highlight disabled info message and position.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
h
zetazeta added a comment.
Guys this is great work. Can we please make the limits configurable? Each
developer will have a different sweet spot. I don't want to burden this
revision, maybe we can make a bug about configuring the limits and leave that
part to someone confortable with the confi
dhaumann added a comment.
Is it correct that highlighting in the document (i.e. KSyntaxHighlighting)
still takes place for the entire line, and this change simply only changes the
fact that KateRenderer stops using the highlighting info after 10 columns?
Prior to accepting this patch
sars added a comment.
The highlighting limit is now returned in a function in KateRenderer as it is
used also in katedocument.cpp for the warning/information message.
INLINE COMMENTS
> mwolff wrote in katerenderer.cpp:400
> this style-change should be submitted independently of this code rev
sars updated this revision to Diff 46957.
sars edited the summary of this revision.
sars added a comment.
Add a message to inform about why the lines are not highlighted.
Add a note about disabled highlighting to the wrapped lines warning.
Increase the default line length limit to 100 000 c
sars retitled this revision from "Disable highlighting for lines longer than
1024 characters." to "WIP:Disable highlighting for lines longer than 1024
characters.".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17241
To: sars, cullmann, vkrause, dhaumann, mwolff
C
