D17298: remove unused docId from result

2018-12-02 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R293:647823d36592: remove unused docId from result (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17298?vs=46680=46743 REVISION DETAIL

D17298: remove unused docId from result

2018-12-02 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Ah, of course, duh! REPOSITORY R293 Baloo BRANCH remove_result_id REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns, ngraham Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

D17298: remove unused docId from result

2018-12-02 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH remove_result_id REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17298: remove unused docId from result

2018-12-02 Thread Stefan Brüns
bruns added a comment. libKF5BalooEngine is not exported to the outside world. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D17298: remove unused docId from result

2018-12-02 Thread Nathaniel Graham
ngraham added a comment. Some of these are public; wouldn't this break ABI compatibility? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns,

D17298: remove unused docId from result

2018-12-02 Thread Alexander Stippich
astippich removed a dependency: D16826: Treat uints the same as ints. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17298: remove unused docId from result

2018-12-02 Thread Alexander Stippich
astippich retitled this revision from "remove unused doc_id from result" to "remove unused docId from result". astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17298 To: astippich, #baloo, bruns Cc: kde-frameworks-devel,