D17315: Avoid potential nullptr access for Document, use reference instead

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4fa98ca84fb3: Avoid potential nullptr access for Document, use reference instead (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17315: Avoid potential nullptr access for Document, use reference instead

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D17315: Avoid potential nullptr access for Document, use reference instead

bruns added a dependent revision: D17324: Move internal helper from BasicIndexingJob to anonymous namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

D17315: Avoid potential nullptr access for Document, use reference instead

bruns updated this revision to Diff 46755. bruns retitled this revision from "Avoid potential nullptr access for Document use reference instead" to "Avoid potential nullptr access for Document, use reference instead". bruns added a comment. reorder patches REPOSITORY R293 Baloo CHANGES

D17315: Avoid potential nullptr access for Document use reference instead

astippich added a comment. In D17315#370404 , @bruns wrote: > In D17315#370298 , @astippich wrote: > > > This one doesn't apply, looks like D17824 is a dependency? > > > D17312

D17315: Avoid potential nullptr access for Document use reference instead

bruns added a comment. In D17315#370298 , @astippich wrote: > This one doesn't apply, looks like D17824 is a dependency? D17312 REPOSITORY R293 Baloo REVISION DETAIL

D17315: Avoid potential nullptr access for Document use reference instead

astippich added a comment. This one doesn't apply, looks like D17824 is a dependency? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D17315: Avoid potential nullptr access for Document use reference instead

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Using a TermGenerator without backing document is