D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Jan Grulich
jgrulich added a comment. In D17350#371674 , @ngraham wrote: > Has the new QML KCM landed now? Or is it in some WIP branch somewhere? It's in a branch in plasma-nm, the branch is called "plasma-kcm", but as I said, it has basically no

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Nathaniel Graham
ngraham added a comment. Has the new QML KCM landed now? Or is it in some WIP branch somewhere? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Marco Martin
mart added a comment. All is in now :) (connection name became Network name as requested) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:7482529530ca: Add the missing api for multilevel KCMs to control the columns (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH phab/missingapi REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-05 Thread Marco Martin
mart added a comment. In D17350#371496 , @jgrulich wrote: > @mart , can you push your changes for plasma-nm so I can try this? sure! can you ship it this too, so i get it all off in? REPOSITORY R296 KDeclarative REVISION DETAIL

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Jan Grulich
jgrulich added a comment. @mart , can you push your changes for plasma-nm so I can try this? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Jan Grulich
jgrulich added a comment. In D17350#371191 , @ngraham wrote: > That plasma-nm QML rewrite is looking totally awesome! How soon can we get it committed? I unfortunately didn't have time to work on that since Akademy so there is no

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Andres Betts
abetts added a comment. Instead of connection name, would it make sense to call it, network name instead? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Marco Martin
mart added a reviewer: jgrulich. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Marco Martin
mart added a comment. F6454962: image.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D17350 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17350: Add the missing api for multilevel KCMs to control the columns

2018-12-04 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY - add currentIndex and depth, which would map to the view in SystemSettings using a Kirigami