D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2019-01-12 Thread gregormi
gregormi added a comment. With respect to bringing this https://phabricator.kde.org/T10279 forward, how should I proceed here? Can this go in as first step (after I removed F10 and F11)? (see also https://phabricator.kde.org/D17443) INLINE COMMENTS > kateview.cpp:700 >

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-26 Thread Christoph Cullmann
cullmann added a comment. I have no issues with freeing Fx keys. But perhaps we should think about that then in a more extended way: Do we really need Fx shortcuts at all for showing the left border stuff? People can add them and actually I would assume you once configure that and be

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-19 Thread gregormi
gregormi added a comment. Yes, those shortcuts exist long time. I would like to change them for these specific reasons which I think are worth to be considered: 1. Introduce a default shortcut pair for "Next / Prev Match" which is useful and currently missing. 2. "Free" some F keys

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-18 Thread Dominik Haumann
dhaumann added a comment. Hm, these shortcuts exist for 15+ years... The extended shortcuts are not used widely in kde at all. Do we really address issues here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: dhaumann, ngraham,

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-09 Thread Nathaniel Graham
ngraham added a comment. Oh! Sorry, please ignore me... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-09 Thread gregormi
gregormi added a comment. In D17442#374054 , @ngraham wrote: > In D17442#373755 , @gregormi wrote: > > > In D17442#373708 , @ngraham wrote: > > > > >

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-09 Thread Nathaniel Graham
ngraham added a comment. In D17442#373755 , @gregormi wrote: > In D17442#373708 , @ngraham wrote: > > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and [Ctrl] + [⇧] + [G].

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-08 Thread Nathaniel Graham
ngraham added a comment. I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and [Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those. REPOSITORY R39

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-08 Thread gregormi
gregormi edited the summary of this revision. gregormi added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

2018-12-08 Thread gregormi
gregormi created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gregormi requested review of this revision. REVISION SUMMARY The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search Match. These shortcuts