D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Reverted. Will find another way. Sorry for the regression, everyone! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh,

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Actually I feel like this regressed the visuals for the file dialog itself in the name of improving the situation for apps that use this view in a sidebar. Unfortunately, since it also regresses performance, I will be reverting it and and will look for another

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

abetts added a comment. +1 for improving visuals REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc: abetts, apol, cfeck, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. In D17461#376509 , @apol wrote: > Hey, this change makes the file dialog crawl on big directories. > For me, going into /usr/include makes the whole application freeze. > > We should consider reverting and trying a

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

apol added a comment. Hey, this change makes the file dialog crawl on big directories. For me, going into /usr/include makes the whole application freeze. We should consider reverting and trying a different approach. REPOSITORY R241 KIO REVISION DETAIL

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f28e34306378: [KDirOperator] Dont squeeze Name column when there isnt enough horizontal… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Cool, landing now. If I can get some assistance, I might try my hand at submitting a Qt patch to add the requested resize mode. REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

cfeck accepted this revision. cfeck added a comment. See also bug 394115 (and I blamed Qt ...) REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc:

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Yeah, I do too. It's certainly more functional. Do you think I should just commit this now? REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg,

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think the proposed change is already an improvement. REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. A slightly nicer solution would appear to be to keep column 0 using `QHeaderView::Stretch` like it already is, but give only that column a minimum size equal to the longest item. That way the name column would dynamically expand as the view was enlarged which keeps

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When a `KDirOperator` view is used in Detailed or Detailed Tree view, when