This revision was automatically updated to reflect the committed changes.
Closed by commit R127:46390781daad: Xdg Decoration Support (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17498?vs=47468&id=47955#toc
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPD
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17498
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 47468.
davidedmundson added a comment.
remove unused
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17498?vs=47339&id=47468
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17498
AFFECTED FILES
zzag added inline comments.
INLINE COMMENTS
> test_xdg_decoration.cpp:104
> +QSignalSpy compositorSpy(m_registry, &Registry::compositorAnnounced);
> +QSignalSpy v6xdgShellSpy(m_registry,
> &Registry::xdgShellUnstableV6Announced);
> +QSignalSpy xdgShellSpy(m_registry, &Registry::xdgSh
davidedmundson marked 5 inline comments as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D17498
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson updated this revision to Diff 47339.
davidedmundson added a comment.
zzag's comments
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17498?vs=47336&id=47339
BRANCH
xdg_deco
REVISION DETAIL
https://phabricator.kde.org/D17498
AFFECTED FI
davidedmundson updated this revision to Diff 47336.
davidedmundson added a comment.
misc cleanups
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17498?vs=47331&id=47336
BRANCH
xdg_deco
REVISION DETAIL
https://phabricator.kde.org/D17498
AFFECTED FILE
zzag added inline comments.
INLINE COMMENTS
> test_xdg_decoration.cpp:178-181
> +
> QTest::addColumn("configuredMode");
> +
> QTest::addColumn("configuredModeExp");
> +QTest::addColumn("setMode");
> +
> QTest::addColumn("setModeExp");
Do we actually use it?
> test_xdg_decoration
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Usual massive boilerplate.
Should allow us to remove the injec
