D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2019-01-30 Thread loh tar
loh.tar added a comment. I often struggle with QtCreator but I can't remember what happens there, sorry. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #k

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2019-01-30 Thread Dominik Haumann
dhaumann added a comment. Fixed: 5a6449c3b3d9bbc2b1bc15a5d5b40d7228f3a406 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, cull

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2019-01-30 Thread Dominik Haumann
dhaumann added a comment. Unfortunately, the change in the .ui file introduced bug https://bugs.kde.org/show_bug.cgi?id=403422 The minimum and maximum were set from 1...5 to -1...-1. Will post a followup patch. @loh.tar Did you remove and add the slider manually again, or how did th

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c287d3858fd7: ViewConfig: Add 'Dynamic Wrap At Static Marker' option (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I played with it, it seems to work reasonable well. Lets give this patch a try ;=) Its optional, if people get issues, we can try to fix them later. (I have seen no ones myself) REP

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-26 Thread Christoph Cullmann
cullmann added a comment. I think the idea makes sense, thought I have no idea if the change in the updateView part is correct ;=) Others? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg Cc: cullmann, kwrite-devel, kde-fram

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-18 Thread loh tar
loh.tar added a comment. - No sure if there must be something at other places considered - This is my second version where the wrap is done ether at the static setting or the view width, whatever is smaller. At first is was always wrapped at the static setting. Then I thought it may this wa

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-18 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch is in "Dynamic Wrap Mode" the text alway