D17905: [frameworks] Do not use light font styles for headings (1/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fdc912468785: [frameworks] Do not use light font styles for headings (1/3) (authored by filipf, committed by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://

D17905: [frameworks] Do not use light font styles for headings (1/3)

ngraham added a comment. In D17905#385834 , @abetts wrote: > I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There shou

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf added subscribers: ngraham, VDG, Plasma, Frameworks. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: #frameworks, #plasma, #vdg, ngraham

D17905: [frameworks] Do not use light font styles for headings (1/3)

abetts added a comment. I don't have a problem with the font as much as I have a problem with the spacing for the title labels. They seem to be super close to checkboxes, other labels and controls. There should be a clear separation. Adding a heavier font to the title label helps a lot but b

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf updated this revision to Diff 48579. filipf added a comment. Found another case of the FontLight variable being set REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17905?vs=48495&id=48579 BRANCH no-light-headings (branched from m

D17905: [frameworks] Do not use light font styles for headings (1/3)

ngraham removed a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plas

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17905: [frameworks] Do not use light font styles for headings (1/3)

rooty added a dependent revision: D17916: [Login and lock screens] Do not use light font styles for the sddm clock. REPOSITORY R242 Plasma Framework (Library) BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma,

D17905: [frameworks] Do not use light font styles for headings (1/3)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Strongly approve for all the reasons given in https://bugs.kde.org/show_bug.cgi?id=402730. Let's wait a bit though to make sure the #plasma

D17905: [frameworks] Do not use light font styles for headings (1/3)

filipf retitled this revision from "[frameworks] Don't use light font styles for headings (1/3)" to "[frameworks] Do not use light font styles for headings (1/3)". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17905 To: filipf, ngraham, #plasma, #v