cullmann accepted this revision.
cullmann added a comment.
Given we have a test, the code is documented and nobody raises large
objections since long over the latest implementation, I think this shall go in
:=)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
loh.tar edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17949
To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel,
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars
loh.tar updated this revision to Diff 51680.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.
- Add autotest
- Don't wrap twice when static wrap is set to
cullmann added a comment.
I am ok with the change, but I would like to have one test case in
REVISION DETAIL
https://phabricator.kde.org/D17949
To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel,
#ktexteditor, gennad, michaelh, ngraham,
loh.tar updated this revision to Diff 50648.
loh.tar added a comment.
- Move logic into document
- Tiny docu fix + cosmettic
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17949?vs=50104=50648
REVISION DETAIL
https://phabricator.kde.org/D17949
AFFECTED FILES
loh.tar added a comment.
> also don't change the behavior of wordwrapping that is used by the view
compared to what we would get by calling wordwrap on the document directly
It's somehow not the case. The document has no such function. It's similar to
ViewPrivate::smartNewline() or
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
please look at the existing tests and expand that. There's e.g.
`KateDocumentTest::testWordWrap` in
`ktexteditor/autotests/src/katedocument_test.cpp`
also don't change the
loh.tar updated this revision to Diff 50104.
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.
- Update 'What's This' hint to reflect new behaviour and to be more precise
- Update 'What's This' hint of dyn
loh.tar updated this revision to Diff 50082.
loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more
comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable".
loh.tar added a comment.
- Use std::unique_ptr for the cursor
- Oops!? Use 'if' instead of
