D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread loh tar
loh.tar added a comment. Interesting. Didn't know that such function exist. Well, it may help to read the handbook... Is there no GUI way to access such stuff? "Read the handbook" lala... Well, word/text wrapping is a field which has many room for improvements. - Adjust as block by

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread Dominik Haumann
dhaumann added a comment. @loh.tar Slightly related: You may want to also have a look at this: https://phabricator.kde.org/source/ktexteditor/browse/master/src/script/data/commands/utils.js$271 In short, there is a command line command (F7) called 'rewrap' that rewraps the selection in a "s

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread loh tar
loh.tar added subscribers: cullmann, dhaumann. loh.tar added a comment. > please add proper tests for this functionality No idea how Because there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-15 Thread Milian Wolff
mwolff requested changes to this revision. mwolff added a comment. This revision now requires changes to proceed. I like what I'm seeing in the screenshot, but please add proper tests for this functionality INLINE COMMENTS > kateview.cpp:2355 > +// Because we shrink and expand lines, we

D17949: ViewPrivate: Make applyWordWrap() more comfortable

2019-01-03 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Don't wrap entire document when nothing is selected but wrap