loh.tar added a comment.
May I ask a stupid question? Is the entire function needed? That's looks to
me somehow like image/picture stuff but I don't find picture stuff in the
Tool->Emmet menu.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17970
To: loh.tar, #k
dhaumann added inline comments.
INLINE COMMENTS
> dhaumann wrote in lib.js:5434
> Being a js-noob, I did some searchin the net and it seems to me that \211 is
> supposed to be octal sequence. On
> https://stackoverflow.com/questions/21071921 it is said that octal sequences
> are optional in th
dhaumann added inline comments.
INLINE COMMENTS
> carewolf wrote in lib.js:5434
> Is that even valid JS? Shouldn\t it be \xHH with hexidecimal?
Being a js-noob, I did some searchin the net and it seems to me that \211 is
supposed to be octal sequence. On https://stackoverflow.com/questions/2107
carewolf added inline comments.
INLINE COMMENTS
> lib.js:5434
> getImageSize: function(stream) {
> - var pngMagicNum = "\211PNG\r\n\032\n",
> - jpgMagicNum = "\377\330",
Is that even valid JS? Shouldn\t it be \xHH with hexidecimal?
R
dhaumann added a comment.
Btw, I committed this, but now the length of the string is 14 characters
instead of 8, so this patch is certainly wrong. But better this than a
completely broken emmet.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17970
To: loh.tar,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:120e8400cad6: Fix broken Emmet (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17970?vs=48698&id=48719
REVISION DETAIL
https://phabricato
dhaumann added subscribers: carewolf, dhaumann.
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
@carewolf This issue was caused by the QtScript to QML migration in
KTextEditor. Could you have a look or pass this on the relevant V4 dev
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
- Improve warning message with line number
BUG: 386151
RE
loh.tar added a comment.
Well, if it is fixed I can't say. At least the error is gone and
"Increment/Decrement" works.
May some guru investigate if its fixed. Obviously is there a problem with
these string constants.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.o
