aacid closed this revision.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D18081
To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
arcpatch-D18081
REVISION DETAIL
https://phabricator.kde.org/D18081
To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
aacid updated this revision to Diff 49034.
aacid added a comment.
remove unrelated cmake changes
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18081?vs=48932=49034
BRANCH
arcpatch-D18081
REVISION DETAIL
https://phabricator.kde.org/D18081
AFFECTED
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> CMakeLists.txt:4
> set(KF5_VERSION "5.54.0") # handled by release scripts
> -set(KF5_DEP_VERSION "5.54.0") # handled by release scripts
> +set(KF5_DEP_VERSION "5.53.0") # handled by release scripts
> project(KPackage VERSION
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
Do not call i18n from global static variables since qcoreapplication is
still not around yet and that makes it fail
