D18662: Add and rename some YaST icon symlinks

ndavis updated this revision to Diff 50739. ndavis added a comment. Update commit message REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18662?vs=50694=50739 BRANCH more-yast (branched from master) REVISION DETAIL

D18662: Add and rename some YaST icon symlinks

ndavis added a comment. I think I'll just land this. It fixes a bug caused by my misunderstanding of how YaST currently works. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh,

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

ndavis retitled this revision from "Add and rename some YaST icon symlinks because of Qt bugs" to "Add and rename some YaST icon symlinks". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel,

D18662: Add and rename some YaST icon symlinks because of Qt bugs

hellcp added a comment. It's not really a workaround, all of those icons are valid when it comes to YaST, however previous batch of YaST icons into Breeze was build on idea that icon `xyz-abc.svg` will fallback to `xyz.svg` inside the same icon theme. In QIcon::fromTheme that is the case

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis added a subscriber: hellcp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

fvogt added a comment. In D18662#403612 , @ndavis wrote: > @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis added a subscriber: fvogt. ndavis added a comment. @fvogt LCP said a Qt bug was the reason that the icons weren't working correctly and that you would know more about it. I never got around to asking you though. Do you know which bug it is? REPOSITORY R266 Breeze Icons REVISION

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ngraham added a comment. General policy surrounding workarounds that are committed to the repo is that you need to know and mention the specific bug(s) you're working around. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18662 To: ndavis, #vdg Cc: ngraham,

D18662: Add and rename some YaST icon symlinks because of Qt bugs

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The icons should have worked as they were because they have the correct fallback names.