D18675: Use different "None" item icon in grid view KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R296:e22529eeed0c: Use different None item icon in grid view KCMs (authored by GB_2). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18675?vs=50774=50775 REVISION

D18675: Use different "None" item icon in grid view KCMs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Master only please. REPOSITORY R296 KDeclarative BRANCH use-different-icon-for-none-item (branched from master) REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2,

D18675: Use different "None" item icon in grid view KCMs

GB_2 edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

GB_2 updated this revision to Diff 50774. GB_2 added a comment. Use new `edit-none` icon REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18675?vs=50724=50774 BRANCH use-different-icon-for-none-item (branched from master) REVISION DETAIL

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404096 , @GB_2 wrote: > In D18675#404090 , @ngraham wrote: > > > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being

D18675: Use different "None" item icon in grid view KCMs

ngraham added a comment. Yeah, the item already has a "None" label; we're just trying to figure out what the icon should be. I think an X is okay choice for suggesting "there's nothing here". REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2,

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404104 , @abetts wrote: > > Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled. > > I see, maybe the label could be more descriptive then? Use something

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. > Seems like a bit too much. BTW, this is the Plasma login splash and there is no text output when disabled. I see, maybe the label could be more descriptive then? Use something like "Black", or "No splash"? REPOSITORY R296 KDeclarative REVISION DETAIL

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404097 , @abetts wrote: > In D18675#404090 , @ngraham wrote: > > > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being

D18675: Use different "None" item icon in grid view KCMs

GB_2 added a comment. In D18675#404090 , @ngraham wrote: > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. Yeah, it's the only X icon, I think we need to

D18675: Use different "None" item icon in grid view KCMs

abetts added a comment. In D18675#404090 , @ngraham wrote: > Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. I agree with you here. It may seem that you

D18675: Use different "None" item icon in grid view KCMs

ngraham added a comment. Hmm, I like the use of an X here, but I'm not sure the red color is appropriate. Nothing is being removed, deleted, or destroyed. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18675 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg,

D18675: Use different "None" item icon in grid view KCMs

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Changes the icon for the "None" item in grid view KCMs (present in the Splash Screen KCM)