D18739: Sync QML module padding to reflect system setting pages

This revision was automatically updated to reflect the committed changes. Closed by commit R295:ab33762a6a60: Sync QML module padding to reflect system setting pages (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18739?vs=51174&id=51185#toc REPOSITORY R295

D18739: Sync QML module padding to reflect system setting pages

ngraham added a comment. Looks like this also fixes https://bugs.kde.org/show_bug.cgi?id=396942 REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma, broulik Cc: ngraham, zzag, broulik, vpilo, kde-frameworks-devel, micha

D18739: Sync QML module padding to reflect system setting pages

zzag added inline comments. INLINE COMMENTS > kcmultidialog.cpp:40-41 > #include > +#include > +#include > It looks like includes are sorted. Maybe keep it that way? REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #pla

D18739: Sync QML module padding to reflect system setting pages

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma, broulik Cc: broulik, vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51174. davidedmundson added a comment. more hacks REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=51165&id=51174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 AFFECTED FILES s

D18739: Sync QML module padding to reflect system setting pages

davidedmundson added a comment. Running kcmshell5 icons style was a good suggestion. We have to change an internal layout and only one of the edges - which leads to this monstrosity :/ REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51165. davidedmundson added a comment. remove hardcoded value REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=51163&id=51165 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18739 AFFECT

D18739: Sync QML module padding to reflect system setting pages

davidedmundson updated this revision to Diff 51163. davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a comment. update REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18739?vs=50

D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. In D18739#407649 , @broulik wrote: > If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. > > kcmshell5 icons style > > > Switch between the t

D18739: Sync QML module padding to reflect system setting pages

broulik added a comment. If you open multiple KCMs switching between QML- and Widget-ones leads to awkward outside margin changes with this patch. kcmshell5 icons style Switch between the two and observe how the sidebar dances (this is likely the same issue as when doing the same

D18739: Sync QML module padding to reflect system setting pages

vpilo added a comment. As mentioned in D18458 , a KCM not based on KCM.GridViewKCM & friends (e.g. a KCM based on Kirigami.Page) will now get extra padding (on Breeze, no scaling, it's of 6px), both on KCMShell and SystemSettings. REPOSITORY R295 KCMUti

D18739: Sync QML module padding to reflect system setting pages

davidedmundson edited the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D18739 To: davidedmundson, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18739: Sync QML module padding to reflect system setting pages

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In systemsettings 6a9df821ecfaa008206a260b20f595136e254821