cullmann commandeered this revision.
cullmann edited reviewers, added: dantti; removed: cullmann.
cullmann added a comment.
> I will abandon it.
I compile syntax-highlighting btw. nightly, too, in the AbsInt compile farm
on Windows (MSVC) and macOS (xcode
cullmann abandoned this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19035
To: cullmann, #framework_syntax_highlighting, dhaumann, vkrause, dantti
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,
demsking, cullmann,
cullmann added a comment.
I think then we should just abandon it, if it has no real benefit at all, or?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19035
To: dantti, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel,
dantti added a comment.
I ended up compiling it using vcpkg toolchain directly on Windows, which
showed this isn't required.
In fact even when cross-compiling this won't fix anything because the tool
must run on the host OS.
So I only still think this is useful because the user
cullmann added a reviewer: vkrause.
cullmann added a comment.
I think I let Volker decide that, for non-cross compile stuff this is more or
less a nop and I never do cross compiling ;)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19035
To: dantti,
dantti added a comment.
I'm not entirely sure this is really needed on Windows, but when
cross-compiling this allowed to search for the katehighlightingindexer.exe
which wouldn't run because I was on Linux...
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
dantti created this revision.
dantti added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dantti requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
