D19092: Add bison minimum version of 2.4.1 due to %code

This revision was automatically updated to reflect the committed changes. Closed by commit R309:6b46411622b0: Add bison minimum version of 2.4.1 due to %code (authored by hindenburg). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19092?vs=51902=55031

D19092: Add bison minimum version of 2.4.1 due to %code

ltoscano added a comment. Ups, sorry! So according https://community.kde.org/Schedules/Frameworks there are no special provisions when the change doesn't touch translatable strings and the change is properly tested. REPOSITORY R309 KService BRANCH bison_min_version (branched from

D19092: Add bison minimum version of 2.4.1 due to %code

pino added a comment. In D19092#440060 , @ltoscano wrote: > Not on the 19.04 branch, ... This is a Framework (kservice). REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL

D19092: Add bison minimum version of 2.4.1 due to %code

ltoscano added a comment. Not on the 19.04 branch, the dependency freeze happened few weeks ago - you may want to ask to release-team@ for an exception if you think it's important there too. REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. Is it OK to commit this now? It looks like the next tagging is April 6th REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks, winterz Cc: winterz,

D19092: Add bison minimum version of 2.4.1 due to %code

winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I'm for this. I never created such a patch because I wasn't sure what minimum version was needed. On Mac, what I do is install the homebrew bison and export

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. ping? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg created this revision. Herald added a project: Frameworks. hindenburg requested review of this revision. REVISION SUMMARY Some Mac OS versions have bison 2.3 even though it is very old. %code is first handled in bison version 2.4; gnu site has 2.4.1 as the earliest 2.4.x version.