This revision was automatically updated to reflect the committed changes.
Closed by commit R286:2ab37ed086d8: Increase precision of frame rate property
(authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19101?vs=52109&id=53020
REVIS
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
ffmpeg_framerate
REVISION DETAIL
https://phabricator.kde.org/D19101
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoor
astippich marked 2 inline comments as done.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19101
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
astippich updated this revision to Diff 52109.
astippich added a comment.
- do not use QString::number
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19101?vs=52103&id=52109
BRANCH
ffmpeg_framerate
REVISION DETAIL
https://phabricator.kde.org/D19
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> formatstrings.cpp:152
> {
> -return QString(value.toString() + i18nc("Symbol of frames per second,
> with space", " fps"));
> +return QString(QString::
astippich removed a dependency: D19100: Cleanup ffmpeg extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19101
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
astippich updated this revision to Diff 52103.
astippich added a comment.
- rebase on master
- use exact value in test
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19101?vs=51917&id=52103
BRANCH
ffmpeg_framerate
REVISION DETAIL
https://phabr
bruns added inline comments.
INLINE COMMENTS
> ffmpegextractortest.cpp:52
> QCOMPARE(result.properties().value(Height).toInt(), 720);
> +QVERIFY(abs(result.properties().value(FrameRate).toDouble() - 23.976) <
> 1e-4);
> }
You can probably use `(24.0/1001)` for the exact value.
REPOSI
astippich added a dependency: D19100: Cleanup ffmpeg extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19101
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abrahams
astippich added a dependent revision: D19102: Fix extraction of aspect ratio
property.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19101
To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, brun
astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
Some video files have frame rates
of 23.976 or similar, req
11 matches
Mail list logo