D19109: [Extractor] Add metadata to extractors

This revision was automatically updated to reflect the committed changes. Closed by commit R286:de81ddb651b1: [Extractor] Add metadata to extractors (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19109?vs=52402=52403 REVISION

D19109: [Extractor] Add metadata to extractors

bruns updated this revision to Diff 52402. bruns added a comment. add AppImage extractor metadata REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19109?vs=51936=52402 BRANCH baseline REVISION DETAIL https://phabricator.kde.org/D19109 AFFECTED

D19109: [Extractor] Add metadata to extractors

bruns edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH extractor_properties REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich,

D19109: [Extractor] Add metadata to extractors

astippich added a comment. also T8079 REPOSITORY R286 KFileMetaData BRANCH extractor_properties REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson,

D19109: [Extractor] Add metadata to extractors

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. I would also like to remove the aliasing mimetypes. But I guess due to the implementation where the mimetype is given as QString, and there is no guarantee that it is obtained from

D19109: [Extractor] Add metadata to extractors

bruns added a comment. In D19109#415710 , @astippich wrote: > In D19109#414968 , @bruns wrote: > > > In D19109#414758 , @astippich wrote: > > > > > A

D19109: [Extractor] Add metadata to extractors

astippich added a comment. In D19109#414968 , @bruns wrote: > In D19109#414758 , @astippich wrote: > > > A few general remarks: > > > > - I really do not like that there are two lists of

D19109: [Extractor] Add metadata to extractors

bruns added a comment. In D19109#414758 , @astippich wrote: > A few general remarks: > > - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync I think this is trivial enough. Also

D19109: [Extractor] Add metadata to extractors

astippich added a comment. A few general remarks: - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync - Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience,

D19109: [Extractor] Add metadata to extractors

bruns retitled this revision from "[Extractor] Add metadata to properties" to "[Extractor] Add metadata to extractors". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel,