D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-23 Thread Dominik Haumann
dhaumann added a comment. >> I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731 > > @dhaumann No comment to this? @cullmann May you? Yes, that is a good idea. The only issue I see is that with Ctrl+H you don't have a clear starting point. May

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-23 Thread loh tar
loh.tar added a subscriber: cullmann. loh.tar added a comment. >> For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. > > I think that may also fix the case example in https://b

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-23 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:7d9bc72a1bb1: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka… (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-23 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19193 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, brun

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-23 Thread Dominik Haumann
dhaumann added a comment. Looks good to me - thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19193 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-22 Thread loh tar
loh.tar added a comment. > For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731 REPOSIT

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-20 Thread loh tar
loh.tar added a comment. For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. May try to fix that when got some +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabric

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

2019-02-20 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19193