This revision was automatically updated to reflect the committed changes.
Closed by commit R244:e4474e7bc1a6: Make it compile without foreach (authored
by mlaurent).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19299?vs=53048=53052
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I see, that's because the old file isn't utf8, for the diff. Well, next time
it'll work ;)
INLINE COMMENTS
> mlaurent wrote in kpluginmetadata.cpp:233
> people was const. So I thought
mlaurent added a comment.
for faceicontest it's phabricator which doesn"t like no UTF8 file
I converted to utf8 with iconv but it still don't like it...
{code}
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014 Nicol341s Alvarez
+ * Copyright (C) 2014 Nicolás Alvarez
-
mlaurent updated this revision to Diff 53048.
mlaurent added a comment.
Fix as requested by david
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19299?vs=52527=53048
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
mlaurent marked an inline comment as done.
mlaurent added inline comments.
INLINE COMMENTS
> dfaure wrote in kpluginmetadata.cpp:233
> needs a const local var, no?
people was const. So I thought that it was not necessary.
But I created it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
I can't review tests/faceicontest.cpp, phabricator thinks it's a binary file.
INLINE COMMENTS
> ktexttohtmltest.cpp:163
> +for (const QString : qAsConst(schemas)) {
> +
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
compile without foreach
REPOSITORY
R244 KCoreAddons
BRANCH
