dpalacio closed this revision.
dpalacio added a comment.
I regained write access and I committed it myself. Sorry for the noise.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh,
dpalacio added a comment.
Could you commit this patch in my stead? I don't have commit access.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dpalacio added a comment.
Yes, all kdirmodel tests pass
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
This makes a lot of sense.
I trust that you checked that kdirmodeltest still passes?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio,
elvisangelaccio added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham added reviewers: Frameworks, Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19313
To: dpalacio, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dpalacio created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dpalacio requested review of this revision.
REVISION SUMMARY
Currently `ExpandToUrl` may fail to fully expand to an existing folder if any
parent folder in the path has several
