This revision was automatically updated to reflect the committed changes.
Closed by commit R291:4ac2a1c5eeba: make it compile without foreach (authored
by mlaurent).
REPOSITORY
R291 KPty
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19319?vs=52699=53041
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R291 KPty
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19319
To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent updated this revision to Diff 52699.
mlaurent added a comment.
Remove not necessary change
REPOSITORY
R291 KPty
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19319?vs=52561=52699
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
apol added a comment.
Looks odd, it's not necessary any changes?
INLINE COMMENTS
> kpty.cpp:88
> public:
> -virtual void setupChildProcess() override
> +void setupChildProcess() override
> {
Unrelated? Commit separately.
REPOSITORY
R291 KPty
REVISION DETAIL
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
compile without foreach
REPOSITORY
R291 KPty
BRANCH
compile_without_foreach
