D19445: Handle variant list in formatting functions

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ffdee4011145: Handle variant list in formatting functions (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55926=56384

D19445: Handle variant list in formatting functions

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > propertyinfotest.cpp:91 > { Property::BitRate, true, 1470, > QStringLiteral("14.7 Mbit/s")}, > +{ Property::BitRate,

D19445: Handle variant list in formatting functions

astippich added a dependent revision: D20528: Change properties attributes for consistency. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19445: Handle variant list in formatting functions

apol added a comment. Patch looks good to me, @bruns note that you still have it set as "changes required". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson,

D19445: Handle variant list in formatting functions

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55926. astippich added a comment. - remove unrequired parenthesis REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=55326=55926 BRANCH generic_display_list REVISION DETAIL

D19445: Handle variant list in formatting functions

apol added inline comments. INLINE COMMENTS > propertyinfo.cpp:650 > +for (const auto& entry : valueList) { > +displayList << (d->formatAsString)(entry); > +} `displayList << d->formatAsString(entry);` REPOSITORY R286 KFileMetaData

D19445: Handle variant list in formatting functions

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 55326. astippich added a comment. - rebase on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54956=55326 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.org/D19445

D19445: Handle variant list in formatting functions

astippich added a comment. ping. This will be beneficial for handling lists regardless of the discussion in D19087 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc:

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 54956. astippich marked an inline comment as done. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=54651=54956 BRANCH generic_display_list REVISION

D19445: Handle variant list in formatting functions

astippich removed a dependent revision: D20013: Use Qt function for string list formatting. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D19445: Handle variant list in formatting functions

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfo.cpp:634 > Don't reinvent Qt functionality: > https://doc.qt.io/qt-5/qlocale.html#createSeparatedList see D20013 REPOSITORY R286

D19445: Handle variant list in formatting functions

astippich added a dependent revision: D20013: Use Qt function for string list formatting. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D19445: Handle variant list in formatting functions

astippich added a dependency: D20012: Fix number localization for properties. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 54651. astippich added a comment. - code style REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=52905=54651 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.org/D19445 AFFECTED

D19445: Handle variant list in formatting functions

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > propertyinfo.cpp:634 > +if (d->valueType == QVariant::StringList || d->valueType == > QVariant::String ) { > +return

D19445: Handle variant list in formatting functions

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Improve the formatting function of KFileMetaData such that