D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-05 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:715ce3c20837: Avoid fractionals in GridDelegate sizes and alignments (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19530?vs=5316

D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-05 Thread Filip Fila
filipf added a comment. In D19530#424922 , @rooty wrote: > A lot easier on the eyes now, really nice fix > > This'll be landing in 5.16? KF 5.57 as far as I can tell. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL

D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-04 Thread Krešimir Čohar
rooty accepted this revision. rooty added a comment. A lot easier on the eyes now, really nice fix REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D19530 To: davidedmundson, #plasma, ngraham, rooty Cc: rooty, ngraham, filipf, kde-frameworks-devel

D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice fix. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D19530 To: davidedmundson, #plasma, ngraham Cc: ngraham, filipf, kde-framewor

D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-04 Thread Filip Fila
filipf added a comment. David this really does fix it! Previews are nice and sharp everywhere now. See before: F6657490: Screenshot_20190304_173527.png And after: F6657492: Screenshot_20190304_231358.png

D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-04 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY The thumbnail object within the Delegate is offset by float amoun