This revision was automatically updated to reflect the committed changes.
Closed by commit R288:4f4298539104: [KUiServerJobTracker] Update destUrl before
finishing the job (authored by broulik).
REPOSITORY
R288 KJobWidgets
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah! See that's the information I was missing (download job + user chooses
interactively). In KIO we typically ask for a dest first, and only then start a
job.
If you could add a word
broulik added a comment.
In plasma-browser-integration I get a download started event by the browser
right away and only when the user chose a download location I will get notified
of that, so the job does not have a `destUrl` in the beginning.
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
dfaure added a comment.
I must be missing something.
How can a job "examine the real destination" without having the URL of the
destination?
Is there some redirection happening or something?
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D19583
To:
broulik added a comment.
Isn't "where the job first has to examine the real destination and only can
then set it and start." and "In plasma-browser-integration I only get the
destination after the job has been started." sufficient?
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
dfaure added a comment.
Looks ok, but the commit log is missing an actual use case. In which case
does the dest URL change, exactly?
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D19583
To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik edited the test plan for this revision.
REPOSITORY
R288 KJobWidgets
REVISION DETAIL
https://phabricator.kde.org/D19583
To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
It is not really meant to be changing after the job started, but there can be
