D19633: Improve consistency of window-* and add more

2019-03-10 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:3bc4079c220e: Improve consistency of window-* and add more (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53571=53607 REVISION

D19633: Improve consistency of window-* and add more

2019-03-10 Thread Noah Davis
ndavis added a comment. window-shade can be added in a later patch so that this one isn't unnecessarily held back REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg, ngraham Cc: ngraham,

D19633: Improve consistency of window-* and add more

2019-03-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R266 Breeze Icons BRANCH window-states (branched from master) REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg, ngraham Cc: ngraham,

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis updated this revision to Diff 53571. ndavis added a comment. - Add window-unpin-symbolic REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53569=53571 BRANCH window-states (branched from master) REVISION DETAIL

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis updated this revision to Diff 53569. ndavis added a comment. - Add window-unpin REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53516=53569 BRANCH window-states (branched from master) REVISION DETAIL

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. In D19633#427965 , @ndavis wrote: > In D19633#427913 , @ngraham wrote: > > > Neat! Very helpful, thanks. > > > > While you're at it, do you think you could add a

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis added a comment. In D19633#427913 , @ngraham wrote: > Neat! Very helpful, thanks. > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 Yes, but I'm not sure

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. Also `window-shade`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Nathaniel Graham
ngraham added a comment. Neat! Very helpful, thanks. While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham,

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis updated this revision to Diff 53516. ndavis edited the test plan for this revision. ndavis added a comment. Rename window-maximized to window-restore for better 3rd party compatibility REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

2019-03-09 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add window-keep-above/below Add window-maximize/maximized/minimize Change