mlaurent updated this revision to Diff 80344.
mlaurent added a comment.
Use m_menu->addActions(m_dropActions);
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19913?vs=80182=80344
BRANCH
compile_without_foreach (branched from master)
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:48f60533b922: [plasma-framework] make it compiles without
foreach (authored by mlaurent).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
apol accepted this revision.
apol added inline comments.
INLINE COMMENTS
> dropmenu.cpp:80
> } else if (m_menu) {
> -foreach (QAction *action, m_dropActions) {
> +for (QAction *action : qAsConst(m_dropActions)) {
> m_menu->addAction(action);
mlaurent added a comment.
Ping ?:)
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19913
To: mlaurent, dfaure
Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n,
mlaurent updated this revision to Diff 80182.
mlaurent added a comment.
Fix comment
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19913?vs=80170=80182
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
ahmadsamir added inline comments.
INLINE COMMENTS
> iconitem.cpp:628
> // setup time.
> -foreach (const QString& overlay, m_overlays) {
> +for (const QString& overlay : qAsConst(m_overlays)) {
> if (!overlay.isEmpty()) {
Coding style
> pluginloader.cpp:328
> const
mlaurent retitled this revision from "[plasma-desktop] make it compiles without
foreach" to "[plasma-framework] make it compiles without foreach".
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
