D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis abandoned this revision. ndavis added a comment. will move to invent.kde.org REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ndavis, #vdg, arvidhansson Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

t-ask added a comment. As I'm quite busy right now I will upload my current SVG version. I did add a very simple more Breeze styled icon (which I think is not the best fit to identify it as a NUM button). F6759017: image.png Maybe someone else

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis commandeered this revision. ndavis edited reviewers, added: arvidhansson; removed: ndavis. ndavis added a comment. Alright. I'll finish it when I have time. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: ndavis, #vdg, arvidhansson Cc: ngraham,

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#439120 , @ndavis wrote: > In D19952#439031 , @arvidhansson wrote: > > > In D19952#438965 , @ndavis wrote: > >

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#439031 , @arvidhansson wrote: > In D19952#438965 , @ndavis wrote: > > > The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#438965 , @ndavis wrote: > The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. The rounded corners and bold 1 are not very breeze like, so I don't think so, unless he changes his design. Unless you still plan to do the icon yourself, you should probably hand off responsibility for the patch to someone else. REPOSITORY R266 Breeze Icons

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#438310 , @ndavis wrote: > In D19952#438130 , @arvidhansson wrote: > > > In D19952#437726 , @ndavis wrote: > >

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#438130 , @arvidhansson wrote: > In D19952#437726 , @ndavis wrote: > > > In D19952#437670 , @arvidhansson wrote: > >

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#437726 , @ndavis wrote: > In D19952#437670 , @arvidhansson wrote: > > > In D19952#437419 , @ndavis wrote: > >

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#437670 , @arvidhansson wrote: > In D19952#437419 , @ndavis wrote: > > > This can be done in the system tray widget instead of making a separate icon for off. Ever

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#437419 , @ndavis wrote: > In D19952#436853 , @arvidhansson wrote: > > > In D19952#436834 , @taskf wrote: > > >

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#436919 , @taskf wrote: > Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436853 , @arvidhansson wrote: > In D19952#436834 , @taskf wrote: > > > There is one issue I'm not sure about. The user might feel pressured to check something if

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ngraham added a comment. In D19952#436919 , @taskf wrote: > Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state of

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Hmm, still I somehow like the stroked version, while I wouldn't recommend using it this particular case. Even the transparent version can easily be controlled the `disabled` state of this icon object. Currently, I think it would be good to add both icons to Breeze

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#436834 , @taskf wrote: > There is one issue I'm not sure about. The user might feel pressured to check something if the symbol is stroked as it fells like "something is wrong". In that case I would

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. There is one issue I'm not sure about. The user might feel pressured to check something if the symbol is stroked as it fells like "something is wrong". In that case I would suggest just using the ON version and make it 50% transparent in OFF mode. REPOSITORY R266

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Here is another try with rounded corners to mimik a keyboard key. To me the stroke is not that a of problem if it goes the other direction, as it feels more natural. Right handed people would probably stroke something that way than it is done with traffic signs or is

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. Here's my attempt: F6711669: montage-breeze-Background.png F6711673: input-numlock-on.16.svg F6711674: input-numlock-on.22.svg REPOSITORY

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. In D19952#436429 , @arvidhansson wrote: > Nice! This icons are really good! Thanks. > Well, I think you (Taskf) know what to do, just tell us if you need a hand. Well, first I need an info which version

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#436427 , @ndavis wrote: > In D19952#436425 , @taskf wrote: > > > Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Yes, the cross is a bit twisted as with a 45° angle it crosses right through the '1' and makes it not that readable. F6711431: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To:

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. In D19952#436425 , @taskf wrote: > Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task. > > They are not polished as you can see from the screenshot. The left version

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

taskf added a comment. Hi, I created some icons a week ago, just didn't post them as @arvidhansson was already on the task. They are not polished as you can see from the screenshot. The left version symbolizes a lock, while the right one, which I like more, symbolizes a keyboard key.

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. You need to make the icons on 16x16px and 22x22px canvases. If you use a grid with 1 line every pixel, it will be easier to make icons look sharp. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc:

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson added a comment. In D19952#435940 , @ndavis wrote: > That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools? I used the font tool in Inkscape and pasted the 1 in the

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a comment. That "1" is too blurry. Did you use the font tool or did you draw it with the pen or rectangle tools? Since this is "numlock" Wouldn't it make more sense to put a "1" inside of a lock? REPOSITORY R266 Breeze Icons REVISION DETAIL

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

ndavis added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19952 To: arvidhansson, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

arvidhansson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arvidhansson requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH num-lock-patch (branched from master) REVISION DETAIL