astippich updated this revision to Diff 54705.
astippich added a comment.
- rename tests
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20020?vs=54685&id=54705
BRANCH
refactor_ffmpeg_tests
REVISION DETAIL
https://phabricator.kde.org/D20020
AFFE
bruns added inline comments.
INLINE COMMENTS
> ngraham wrote in ffmpegextractortest.h:33
> What is metadata data? :p
Data for testing metadata ;-)
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20020
To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #balo
bruns added a comment.
Can you rename the `videoTest()`, so it is clear one is about intrinsic video
properties, and the other about explicit information stored in tags/metadata
bitstreams? Also add a comment saying so.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.k
ngraham added inline comments.
INLINE COMMENTS
> ffmpegextractortest.h:33
> +void videoTestMetaData();
> +void videoTestMetaData_data();
> };
What is metadata data? :p
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20020
To: astippich, ngraham, bruns
C
astippich added a dependent revision: D20021: Add support for extracting data
from ogg and ts files.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20020
To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,
ast
astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REPOSITORY
R286 KFileMetaData
BRANCH
refactor_ffmpeg_tests
REVISION DETAIL
