D20059: Take clang-cl into account.

2019-03-29 Thread Christian Mollekopf
cmollekopf added a comment. FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything. I think clang-cl should receive all arguments it understands with this patch. REPOSITORY R240 Extra CMake Modules

D20059: Take clang-cl into account.

2019-03-26 Thread Aleix Pol Gonzalez
apol added a comment. LGTM, looks like clang-cl will be missing a few arguments though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20059: Take clang-cl into account.

2019-03-26 Thread Aleix Pol Gonzalez
apol added a reviewer: Windows. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf, #windows Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20059: Take clang-cl into account.

2019-03-26 Thread Christian Mollekopf
cmollekopf added a comment. There was already an earlier (abandoned) attempt at this: https://git.reviewboard.kde.org/r/128779 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20059 To: cmollekopf Cc: kde-frameworks-devel, kde-buildsystem, michaelh,

D20059: Take clang-cl into account.

2019-03-26 Thread Christian Mollekopf
cmollekopf created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cmollekopf requested review of this revision. REVISION SUMMARY clang-cl is an MSVC compatible frontend for clang, and as such takes MSVC style