This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c244729b6771: Enable glGetGraphicsResetStatus support by
default on Qt = 5.13 (authored by davidedmundson).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
ngraham added a comment.
Given the testing already done by users, yeah, I think this is safe to land.
+1
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20087
To: davidedmundson, apol
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
¯\_(ツ)_/¯
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20087
To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham,
davidedmundson added a comment.
It's autogenerated, so non-trivial
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D20087
To: davidedmundson
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
apol added inline comments.
INLINE COMMENTS
> qtquicksettings.cpp:47
> +if (s.graphicsResetNotifications() ||
> +QLibraryInfo::version() >= QVersionNumber(5, 13, 0)) {
> format.setOption(QSurfaceFormat::ResetNotification);
Shouldn't this check be in
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
I added support in Qt for handling Nvidia's glGetGraphicsResetStatus
flag, which reports when it has
