This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3f3b6560f963: [timeline] Canonicalize Url (authored by
bruns).
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20101?vs=55049=55054
REVISION DETAIL
ngraham accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20101
To: bruns, #baloo, #frameworks, poboiko, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,
bruns updated this revision to Diff 55049.
bruns added a comment.
use explicit type name
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20101?vs=55007=55049
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20101
AFFECTED FILES
ngraham added inline comments.
INLINE COMMENTS
> kio_timeline.cpp:134
> {
> +auto canonicalUrl = canonicalizeTimelineUrl(url);
> +if (url != canonicalUrl) {
Any reason not to make the type explicit?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D20101
To:
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
In case someone removes everything but the
