This revision was automatically updated to reflect the committed changes.
Closed by commit R286:25eca3185ffa: Test ffmpeg extractor using mime type
helper (authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20121?vs=55301=55425
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
ffmpeg_mimetypes
REVISION DETAIL
https://phabricator.kde.org/D20121
To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,
astippich updated this revision to Diff 55301.
astippich added a comment.
- add friend and use member function
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20121?vs=55059=55301
BRANCH
ffmpeg_mimetypes
REVISION DETAIL
bruns added inline comments.
INLINE COMMENTS
> ffmpegextractortest.cpp:27
> #include
> +//#include
>
remove comment
> astippich wrote in ffmpegextractor.cpp:64
> This is quite specific to the codec. ExtractorCollection should handle this
> case I think (mime type of file is more specific
astippich added inline comments.
INLINE COMMENTS
> ffmpegextractor.cpp:64
> QStringLiteral("video/x-msvideo"),
> +QStringLiteral("video/x-theora+ogg"),
> };
This is quite specific to the codec. ExtractorCollection should handle this
case I think (mime type of file is more specific
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
Use mime type helper to test ffmpeg extractor and add
new mime
