D20358: Force en locale for propertyinfotest

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ccc0e0b9238e: Force en locale for propertyinfotest (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=56002=56134 REVISION

D20358: Force en locale for propertyinfotest

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 56002. astippich added a comment. - add comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55760=56002 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES

D20358: Force en locale for propertyinfotest

bruns added a comment. otherwise, good to go. INLINE COMMENTS > propertyinfotest.cpp:94 > QTest::addColumn("value"); > QTest::addColumn("expected"); > QTest::addColumn("maybeLocalized"); Can you add a comment for "expected", telling the expected value uses the

D20358: Force en locale for propertyinfotest

astippich added a comment. It is a documentation bug. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20358: Force en locale for propertyinfotest

astippich added a comment. https://bugreports.qt.io/browse/QTBUG-75069 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20358 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D20358: Force en locale for propertyinfotest

astippich added a comment. There already was a bug report some time ago https://bugreports.qt.io/browse/QTBUG-15488 looks like it regressed. The given test in the bug report also does not work here. I will open a new one. REPOSITORY R286 KFileMetaData REVISION DETAIL

D20358: Force en locale for propertyinfotest

astippich updated this revision to Diff 55760. astippich added a comment. - use enum REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20358?vs=55684=55760 BRANCH fix_test REVISION DETAIL https://phabricator.kde.org/D20358 AFFECTED FILES

D20358: Force en locale for propertyinfotest

bruns added inline comments. INLINE COMMENTS > astippich wrote in propertyinfotest.cpp:51 > "en_US" also fixes the test for me... Can you open a upstream Qt bug for the differences you see between C and en_US? REPOSITORY R286 KFileMetaData REVISION DETAIL

D20358: Force en locale for propertyinfotest

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:51 > This is somewhat strange ... > > According to > https://doc.qt.io/qt-5/qlocale.html#Language-enum > > > The "C" locale is identical in behavior to English/UnitedStates. > > So either "en" is not

D20358: Force en locale for propertyinfotest

bruns added inline comments. INLINE COMMENTS > propertyinfotest.cpp:51 > if (!m_useLocalization) { > -QLocale().setDefault(QLocale::c()); > +QLocale().setDefault(QLocale(QStringLiteral("en"))); > } This is somewhat strange ... According to

D20358: Force en locale for propertyinfotest

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Fix CI propertyinfotest REPOSITORY R286 KFileMetaData BRANCH