D20433: Use mount point returned from DBus instead of using property value

nicolasfella abandoned this revision. nicolasfella added a comment. The issue has been fixed in another commit REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

nicolasfella added a comment. In D20433#447667 , @bruns wrote: > This approach is completely wrong. > > The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the

D20433: Use mount point returned from DBus instead of using property value

bruns added a comment. This approach is completely wrong. The right approach is to wait for the information in a PropertiesChanged signal, and only when the mountpoint has been set in the property propage the signal. This whole "our information is inconsistent, lets query for it

D20433: Use mount point returned from DBus instead of using property value

broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:35 > StorageAccess::StorageAccess(Device *device) > -: DeviceInterface(device), m_setupInProgress(false), > m_teardownInProgress(false), m_passphraseRequested(false) > +: DeviceInterface(device),

D20433: Use mount point returned from DBus instead of using property value

broulik added a reviewer: bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

nicolasfella reopened this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20433 To: nicolasfella, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20433: Use mount point returned from DBus instead of using property value

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:3ed42e887066: Use mount point returned from DBus instead of using property value (authored by nicolasfella).

D20433: Use mount point returned from DBus instead of using property value

nicolasfella created this revision. nicolasfella added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY There is a slight time frame (~2ms) where mount has returned but the