D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent added a comment. I will look at it REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: kossebau, cfeck, aacid, cgiboudeaux, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20489: [KIO] Make it compile without foreach (Step 1)

kossebau added a comment. @mlaurent Hi, sorry to default to you here, but given the risks with foreach porting (I have done my own share of mistakes in such despite all concentration :) ) https://bugs.kde.org/show_bug.cgi?id=408801 might be triggered by one of this here, have not yet

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. Yes, the pitfalls are well known. 1. don't modify the container being iterated upon (from inside the loop) 2. don't use qAsConst on temporaries and for performance reasons, "don't use range-for over a non-const container", but that's of course not as bad as

D20489: [KIO] Make it compile without foreach (Step 1)

cfeck added a comment. Do we understand all possible regressions that this can cause? If yes, where are they documented so that we can verify? See bug 406426. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cfeck, aacid, cgiboudeaux,

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. I view the KF5 changelog as the list of things that can be useful to the users of the frameworks (i.e. application developers). When we add API, fix a bug, or change dependencies, that's useful for them to know. When we repair a unittest, fix typos in comments,

D20489: [KIO] Make it compile without foreach (Step 1)

aacid added a comment. h, ok, i don't know why we wouldn't want things like this to now show in the autogenerated changelog, but ok, your call :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: aacid, cgiboudeaux,

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. GIT_SILENT is "trivial, don't look at the commit" -- at least it used to be. Not really applicable to commits such as this one REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: aacid, cgiboudeaux,

D20489: [KIO] Make it compile without foreach (Step 1)

aacid added a comment. In D20489#449216 , @dfaure wrote: > FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of

D20489: [KIO] Make it compile without foreach (Step 1)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3f482d8981b0: [KIO] Make it compile without foreach (Step 1) (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20489?vs=56136=56150 REVISION

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent edited the summary of this revision. REPOSITORY R241 KIO BRANCH port_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. FYI NO_CHANGELOG doesn't have to be in the first line (which would make noise in phab review titles for new requests, etc). It can be a line of its own, for example towards the end of the

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent added a comment. "But yeah, if people could add NO_CHANGELOG somewhere in the commit log it would make this easier. Laurent, can you do that for mechanical commits such as this one?" no problem for adding [NO_CHANGELOG] in commit message REPOSITORY R241 KIO REVISION DETAIL

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent updated this revision to Diff 56136. mlaurent added a comment. Add missing qAsConst REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20489?vs=56058=56136 BRANCH port_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D20489

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in globaltest.cpp:110 > qAsConst? I guess QFETCH doesn't make the variables const. indeed. > dfaure wrote in kdirmodel.cpp:263 > qAsConst Ah yep I thought that it was the args from method. I will fix it soon REPOSITORY R241 KIO

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure added a comment. Yep, but extracting changelogs from commit logs can be mostly automated, including filtering out many commits with the same first line. It's what I do in `g...@git.kde.org:sysadmin/release-tools` branch `frameworks/5.0` file `parse_changelogs.pl`. But yeah, if

D20489: [KIO] Make it compile without foreach (Step 1)

cgiboudeaux added a comment. In D20489#449133 , @dfaure wrote: > cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu,

D20489: [KIO] Make it compile without foreach (Step 1)

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu,

D20489: [KIO] Make it compile without foreach (Step 1)

mlaurent retitled this revision from "[KIO] Make to compile without foreach (Step 1)" to "[KIO] Make it compile without foreach (Step 1)". mlaurent edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc:

D20489: [KIO] Make to compile without foreach (Step 1)

cgiboudeaux added a comment. In D20489#448703 , @mlaurent wrote: > what is the problem with title ? "Make to compile without foreach" it's missing words or some have to be changed. The summary also lacks explanations *why* this

D20489: [KIO] Make to compile without foreach (Step 1)

mlaurent added a comment. what is the problem with title ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make to compile without foreach (Step 1)

cgiboudeaux added a comment. Please fix the summary REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20489 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make to compile without foreach (Step 1)

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port a lot of foreach/FOREACH (still 220 items) TEST PLAN autotest ok