dfaure added a comment.
It's common to say "I have 3 columns everywhere", that's what tree models
look like.
And if you have zero rows somewhere, it doesn't matter how many columns you
have, that's still "nothing".
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:794d10a834a7: KCharSelects internal model: ensure
rowCount() is 0 for valid indexes (authored by dfaure).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D20506?vs=56138=56140#toc
REPOSITORY
pino added a comment.
Shouldn't the same applied to `columnCount` too?
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20506
To: dfaure, cfeck
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
KF5 coding style:
if (...) {
...
}
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20506
To: dfaure, cfeck
Cc:
dfaure created this revision.
dfaure added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
This isn't a tree model.
QAbstractTableModel's
